RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

Andreas Heger github.com+85555697+andreas-heger at openjdk.java.net
Wed Jun 9 19:41:14 UTC 2021


On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix looks promising. Have you tested this on Windows with Hi-DPI to make sure there is no impact?

No, I only have got MacOS on retina / non retina and a non Hi-DPI Ubuntu system available for tests, but no Windows.

> Would you be able add an automated test case that fails (only on Mac retina) without the fix and passes (on all platforms) with your fix? Hi-DPI fixes are often tricky to test in an automated test, so if not, we can use the existing manual test.

I'm not very experienced in automated tests in general and a test which verifies graphic output might be really challenging. I can take a look at it, but please don't expect any results for the next couple of weeks, or any at all.

-------------

PR: https://git.openjdk.java.net/jfx/pull/531


More information about the openjfx-dev mailing list