RFR: 8234920: Add SpotLight to the selection of 3D light types [v21]

Nir Lisker nlisker at openjdk.java.net
Fri Jun 11 01:24:57 UTC 2021


On Tue, 8 Jun 2021 14:51:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed doc review comments
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java line 106:
> 
>> 104:             assertEquals(FAIL_MESSAGE, lambertSample * attn, sampledBlue, DELTA);
>> 105: 
>> 106: 
> 
> Unneeded extra blank line?

I wanted to separated the 2 tests, but a better way was to extract a method.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334


More information about the openjfx-dev mailing list