RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v9]
Ambarish Rapte
arapte at openjdk.java.net
Mon Jun 14 07:05:55 UTC 2021
On Fri, 11 Jun 2021 20:26:24 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> The documentation for `ObservableListBase.nextRemove` states that a single change always refers to the current state of the list, which likely means that multiple disjoint removed ranges need to be applied in order, otherwise the next change's `getFrom` doesn't refer to the correct index.
>>
>> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, which means that subsequent removals will refer to the wrong index when retrieving the removed elements. This PR fixes the calculation of the current index.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> changes as per review comments
Looks good to me.
-------------
Marked as reviewed by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/478
More information about the openjfx-dev
mailing list