RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]

[Ambarish Rapte]

On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> ~~Question: I was wondering, should I create a ticket for this as well? Given the fact that I don't have an https://bugs.openjdk.java.net account, I need to use the official bug reporting tool, which looked a bit overkill to me since someone needs to check my created ticket, while this PR is only affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform directly.~~
>> EDIT: Thank you, Kevin. :)
>> 
>> This PR fixes the errors you get when cloning and working with OpenJFX in IntelliJ IDE:
>> - The **.idea/misc.xml** is modified to use **JDK_11** as language level instead of JDK_8. 
>> -> This is the language level shown inside the **Project Structure**. (File -> Project Structure...)
>> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, .idea/graphics.iml** are modified to include/recognize the shims (as test resource, this is very similar to the configuration inside the .classpath file from Eclipse)
>> - EDIT: The projects are now recognized by IntelliJ-gradle (**.idea/gradle.xml**, **.idea/compiler.xml**)
>> 
>> **-> With this, I can run all normal tests with IntelliJ**
>> 
>> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is overriding the settings on next gradle reload): 
>> - IntelliJ is not detecting javafx.graphic inside the shims
>> - All javafx.* dependencies are not found for the system tests
>> 
>> **-> If someone has a solution, feel free to comment :)**
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverted whitespace made by IntelliJ

>From the gradle documentation: [Skipping Javadocs and sources](https://docs.gradle.org/current/userguide/dependency_verification.html#sec:skipping-javadocs)
The verification of auto downloaded *-sources.jar files can be skipped using following change. This way we can avoid deleting the `verification-metadata.xml` file.


diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml
index abacd0b05b..0a3d33726d 100644
--- a/gradle/verification-metadata.xml
+++ b/gradle/verification-metadata.xml
@@ -3,6 +3,9 @@
    <configuration>
       <verify-metadata>true</verify-metadata>
       <verify-signatures>false</verify-signatures>
+      <trusted-artifacts>
+         <trust file=".*-sources[.]jar" regex="true"/>
+      </trusted-artifacts>
    </configuration>
    <components>
       <component group="" name="ffmpeg-3.3.3" version="">



I tested this change in addition to the PR changes, dependency verification does not fail with this change but fails without.
Can you please verify and test this change preferably on a clean repo by creating a new IntelliJ project.

-------------

PR: https://git.openjdk.java.net/jfx/pull/506