Integrated: 8268219: hlsprogressbuffer should provide PTS after GStreamer update
Alexander Matveev
almatvee at openjdk.java.net
Wed Jun 16 21:52:19 UTC 2021
On Sat, 12 Jun 2021 00:10:55 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - Reverted JDK-8268152 fix in gstbaseparse.c, since it is no longer needed.
> - Our hlsprogressbuffer outputs buffers in time format, but without any PTS. After GStreamer update mpregparser no longer tries to figure out timestamps if stream in time format and it will assume that upstream provides timestamps. Fixed by providing starting timestamp at the beginning or after seek. In this case mpegparser able to figure out timestamps and will provide them for each buffer downstream.
> - Segment start was also incorrect it should be seek position, otherwise after seek playback waits for seek time. For example if we seek to 2 min, mediaplayer hangs for 2 min and only after that resumes playback. I think it worked before, since mpegparser handled PTS before.
This pull request has now been integrated.
Changeset: 98138c84
Author: Alexander Matveev <almatvee at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/98138c84a7f286731ad12dd5c533cd3fa265bf56
Stats: 19 lines in 2 files changed: 13 ins; 4 del; 2 mod
8268219: hlsprogressbuffer should provide PTS after GStreamer update
Reviewed-by: kcr, arapte
-------------
PR: https://git.openjdk.java.net/jfx/pull/532
More information about the openjfx-dev
mailing list