RFR: 8252238: TableView: Editable (pseudo-editable) cells should respect the row editability

[Jeanette Winzenburg]

On Fri, 18 Jun 2021 10:14:40 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/TableCell.java line 310:
>> 
>>> 308:                 (table != null && !table.isEditable()) ||
>>> 309:                 (column != null && !column.isEditable()) ||
>>> 310:                 (row != null) && !row.isEditable()) {
>> 
>> Incorrect Line ---- "(row != null) && !row.isEditable())"
>> Correction required ----  "(row != null && !row.isEditable()))"
>> 
>> Refer similar line which is rightly implemented in TreeTableCell.java.
>
> darn .. you certainly have the better eyes :)))

Hmm .. this should have been be found by a test ..  having a combination table == null, column == null, row == null would throw. But then, test coverage is .. ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/529