RFR: 8234920: Add SpotLight to the selection of 3D light types [v26]
Kevin Rushforth
kcr at openjdk.java.net
Fri Jun 18 13:26:36 UTC 2021
On Thu, 17 Jun 2021 19:31:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed method call in glsl shaders
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vsConstants.h line 58:
>
>> 56: float4x3 mBones[MAX_BONES] : register(c35);
>> 57:
>> 58: float4 gReserved240[16] : register(c240);
>
> `gReserved240` is now at the wrong location (it should be 245), so if it were ever used it would be a problem. It should be updated to avoid confusion at least.
I think the size should be updated to 11 as well (since we probably don't want to go past 256).
-------------
PR: https://git.openjdk.java.net/jfx/pull/334
More information about the openjfx-dev
mailing list