RFR: 8264137: Suppress deprecation and removal warnings of internal methods

[Kevin Rushforth]

On Mon, 21 Jun 2021 11:24:39 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation" warnings. I have created separate commits for each type of warnings for the ease of review.
> 
> `gradle --info -PLINT="deprecation,removal"` -- results in warnings during build without this PR and results in no warnings with this PR.

I tested this patch, and verified that it does eliminate the deprecation and removal warnings when building the sdk.

There are still a few warnings when compiling the tests. I ran the following command:


$ gradle --continue --info -PLINT="deprecation,removal" test


I get the following deprecation warnings:


modules\javafx.graphics\src\shims\java\javafx\scene\input\GestureEventShim.java:48: warning: [deprecation] GestureEvent(Object,EventTarget,EventType<? extends GestureEvent>) in GestureEvent has been deprecated
modules\javafx.graphics\src\test\java\test\javafx\css\StylesheetTest.java:628: warning: [deprecation] toURL() in File has been deprecated
modules\javafx.graphics\src\test\java\test\javafx\scene\Scenegraph_eventHandlers_Test.java:342: warning: [deprecation] EventType() in EventType has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\chart\XYChartTest.java:92: warning: [deprecation] set(S,V,StyleOrigin) in CssMetaData has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\LabeledTest.java:768: warning: [deprecation] set(S,V,StyleOrigin) in CssMetaData has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\TreeItemTest.java:201: warning: [deprecation] getNodeLevel(TreeItem<?>) in TreeView has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\TreeItemTest.java:208: warning: [deprecation] getNodeLevel(TreeItem<?>) in TreeView has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\TreeItemTest.java:217: warning: [deprecation] getNodeLevel(TreeItem<?>) in TreeView has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\TreeItemTest.java:231: warning: [deprecation] getNodeLevel(TreeItem<?>) in TreeView has been deprecated
modules\javafx.controls\src\test\java\test\javafx\scene\control\TreeItemTest.java:232: warning: [deprecation] getNodeLevel(TreeItem<?>) in TreeView has been deprecated
modules\javafx.fxml\src\test\java\test\com\oracle\javafx\fxml\test\TestLoadPerformance.java:107: warning: [deprecation] XMLReaderFactory in org.xml.sax.helpers has been deprecated
tests\system\src\test\java\test\robot\com\sun\glass\ui\monocle\input\devices\TestTouchDevices.java:46: warning: [deprecation] newInstance() in Class has been deprecated
tests\system\src\test\java\test\robot\javafx\embed\swing\JFXPanelTest.java:95: warning: [deprecation] BUTTON1_MASK in InputEvent has been deprecated
tests\system\src\test\java\test\robot\javafx\embed\swing\JFXPanelTest.java:96: warning: [deprecation] BUTTON1_MASK in InputEvent has been deprecated
tests\system\src\test\java\test\robot\javafx\embed\swing\NonFocusableJFXPanelTest.java:74: warning: [deprecation] BUTTON1_MASK in InputEvent has been deprecated
tests\system\src\test\java\test\robot\javafx\embed\swing\NonFocusableJFXPanelTest.java:75: warning: [deprecation] BUTTON1_MASK in InputEvent has been deprecated


and the following removal warnings:


modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:34: warning: [removal] timeStyle in DateTimeStringConverter has been deprecated and marked for removal
modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:38: warning: [removal] pattern in DateTimeStringConverter has been deprecated and marked for removal
modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:42: warning: [removal] dateStyle in DateTimeStringConverter has been deprecated and marked for removal
modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:46: warning: [removal] getDateFormat() in DateTimeStringConverter has been deprecated and marked for removal
modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:50: warning: [removal] dateFormat in DateTimeStringConverter has been deprecated and marked for removal
modules\javafx.base\src\shims\java\javafx\util\converter\DateTimeStringConverterShim.java:54: warning: [removal] locale in DateTimeStringConverter has been deprecated and marked for removal


You can either fix it as part of this bug fix or else file a follow-on bug for the tests.

-------------

PR: https://git.openjdk.java.net/jfx/pull/538