RFR: 8252238: TableView: Editable (pseudo-editable) cells should respect the row editability [v2]

[Marius Hanl]

On Fri, 18 Jun 2021 10:01:42 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java line 327:
> 
>> 325: 
>> 326:     @Test
>> 327:     public void testCellInUneditableRowIsNotEditable() {
> 
> I recommend adding tests for cell.startEdit() using all combinations of TableView, TableColumn and TableRow editable states.

done

> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableCellTest.java line 638:
> 
>> 636:     @Test
>> 637:     public void testCellInUneditableRowIsNotEditable() {
>> 638:         tree.setEditable(true);
> 
> I recommend adding tests for cell.startEdit() using all combinations of TreeTableView, TreeTableColumn and TreeTableRow editable states.

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/529