RFR: 8252238: TableView: Editable (pseudo-editable) cells should respect the row editability

Marius Hanl mhanl at openjdk.java.net
Tue Jun 22 12:39:31 UTC 2021


On Fri, 18 Jun 2021 10:23:33 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> > I created a follow-up issues for fixing all the sub Tree- and TableCell implementation which do not count the row editability in:
> > [JDK-8268295](https://bugs.openjdk.java.net/browse/JDK-8268295)
> 
> as already commented in the follow-up - I think that it will not be needed after fixing the precondition violation (there are none for any of the cell.xxEdit methods, so the concrete classes must not introduce any) [JDK-8188026](https://bugs.openjdk.java.net/browse/JDK-8188026). The impl pattern will be something like
> 
> ```
> public void startEdit() {
>      if (isEditing()) return;
>      super.startEdit();
>      if (!isEditing()) return;
>      // config edit state
> } 
> ```
> 
> Thus row editable will already be taking into account by super.

I like this idea. Then only the CheckBox... implementations needs to be adjusted. :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/529


More information about the openjfx-dev mailing list