RFR: 8234920: Add SpotLight to the selection of 3D light types [v24]

[Ambarish Rapte]

On Wed, 16 Jun 2021 13:29:03 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> I also see the same problem as Ambarish does when I run it on my older MacBook Pro with integrated graphics. I tracked it down to a bug in the newly added `computeLight` method in the GLSL shaders. See my inline comments. When I apply that fix it works fine for me on my older MacBook. Additionally, my VirtualBox Linux system now works as expected. Basically, you were getting lucky that it worked at all on the graphics cards it did work on.
>> 
>> While you are making changes to the shaders, I think it's time to change the GLSL shaders to use `computeSpotlightFactor` and comment (or ifdef) out the other two, and similarly change the HLSL shaders to use `computeSpotlightFactor3`.
>
>> When I apply that fix it works fine for me on my older MacBook.
> 
> With the change, It works fine on my mac machine too.

> @arapte can you file a JBS bug for this?

Reported the issue here: [JDK-8269133](https://bugs.openjdk.java.net/browse/JDK-8269133)

-------------

PR: https://git.openjdk.java.net/jfx/pull/334