RFR: 8165214: ListView.EditEvent.getIndex() does not return the correct index [v2]
Jeanette Winzenburg
fastegal at openjdk.java.net
Tue Jun 22 16:28:56 UTC 2021
On Tue, 22 Jun 2021 15:36:04 GMT, Johan Vos <jvos at openjdk.org> wrote:
>
>
> This looks the correct approach indeed. Tests fail before and succeed after.
> That is, the first test succeeds before as well, but it makes sense as there is no action that would change the index. So I don't think it is accidentally passing?
maybe "accidentally" is wrong word :) I meant it in the sense I summarized in [JDK-8266969](https://bugs.openjdk.java.net/browse/JDK-8266969): all cell types have issues with configuring edit events with incorrect locations, some take the control's location at the time of the cancel (like ListCell), some take the cell's. For all there are execution paths that carry the correct (which I call "accidental") and some that carry the wrong location. For ListCell the "accidentally" correct locations are set on cell-reuse and after cancel on the cell, the incorrect are all others.
-------------
PR: https://git.openjdk.java.net/jfx/pull/539
More information about the openjfx-dev
mailing list