Integrated: 8165214: ListView.EditEvent.getIndex() does not return the correct index

Jeanette Winzenburg fastegal at openjdk.java.net
Wed Jun 23 07:46:27 UTC 2021


On Mon, 21 Jun 2021 12:27:37 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Issue was that the cancel event carried the listView's editingIndex at the time of firing the event - that's wrong nearly always (because the list's editing state/index might have changed between start and cancel, f.i. due to calling list.edit(someDifferentIndex)). 
> 
> Fixed by keeping the index at startEdit and using that in cancelEdit (similar approach as in TreeCell fix [TreeCell fix JDK-8265210](https://bugs.openjdk.java.net/browse/JDK-8265210). 
> 
> Added tests that are failing (and one that was accidentally passing) before, all passing after.

This pull request has now been integrated.

Changeset: 04493e55
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/04493e55e8ccb98d308a0ed73a20ca31fe868bc1
Stats:     105 lines in 2 files changed: 98 ins; 4 del; 3 mod

8165214: ListView.EditEvent.getIndex() does not return the correct index

Reviewed-by: jvos, aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/539


More information about the openjfx-dev mailing list