RFR: 8234920: Add SpotLight to the selection of 3D light types [v28]

Nir Lisker nlisker at openjdk.java.net
Wed Jun 23 22:37:16 UTC 2021


On Wed, 23 Jun 2021 20:07:02 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Grouped vec3's together
>
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main.vert line 40:
> 
>> 38:     vec3 attn;
>> 39:     float range;
>> 40:     vec3 dir;
> 
> These need to be reordered to match the changes in the fragment shaders. As it is, it causes a shader link error.

Sorry, I can't test the fix on Linux for now. I hope made the change, but didn't verify that it works.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334


More information about the openjfx-dev mailing list