RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

Michael Strauß mstrauss at openjdk.java.net
Thu Jun 24 02:23:27 UTC 2021


On Thu, 24 Jun 2021 01:00:54 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes as per review
>
> modules/javafx.base/src/main/java/javafx/beans/property/Property.java line 68:
> 
>> 66: 
>> 67:     /**
>> 68:      * Removes a unidirectional binding that was established with {@link #bind(ObservableValue)}.
> 
> Why "**a** unidirectional binding" and not "**the**"? "a" implies that there can be more than one binding at the same time. At least that's how I read it.

That's an interesting observation. The way I read it, "the" sounds very specific, like we're talking about a particular binding to a particular source. However, `unbind()` doesn't only remove _one_ particular binding, it removes _any_ particular binding of the infinite number of particular bindings that can exist (although not at the same time), or no binding at all if the property is not bound.

That being said, if you have a stronger opinion on this, please go ahead and make the call.

-------------

PR: https://git.openjdk.java.net/jfx/pull/533


More information about the openjfx-dev mailing list