RFR: 8267554: Support loading stylesheets from data-URIs [v6]
Kevin Rushforth
kcr at openjdk.java.net
Fri Jun 25 13:35:08 UTC 2021
On Fri, 25 Jun 2021 12:07:23 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/StyleManagerTest.java line 1171:
>
>> 1169: assertEquals(Color.BLUE, rect.getFill());
>> 1170: } finally {
>> 1171: Application.setUserAgentStylesheet(uaStylesheet);
>
> This line in `finally` block results in `ClassNotFoundException`
>
> Run the tests as below to get the log-
>
> `gradle --info :graphics:test &> test.log`
Good catch. The reason for this is that the default Stylesheet is in the `javafx.controls` module, which is not available when running unit tests in the `javafx.graphics` module. I recommend to either `@Ignore` this test or else reset it to an empty style sheet (which is effectively what it will be for `javafx.graphics` tests, since the platform initialization code that sets up the default stylesheet is never called for these tests).
-------------
PR: https://git.openjdk.java.net/jfx/pull/536
More information about the openjfx-dev
mailing list