Integrated: 8196065: ListChangeListener getRemoved() returns items that were not removed.

Michael Strauß mstrauss at openjdk.java.net
Mon Jun 28 09:59:07 UTC 2021


On Fri, 23 Apr 2021 03:19:03 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> The documentation for `ObservableListBase.nextRemove` states that a single change always refers to the current state of the list, which likely means that multiple disjoint removed ranges need to be applied in order, otherwise the next change's `getFrom` doesn't refer to the correct index.
> 
> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, which means that subsequent removals will refer to the wrong index when retrieving the removed elements. This PR fixes the calculation of the current index.

This pull request has now been integrated.

Changeset: c4cc9988
Author:    Michael Strauß <mstrauss at openjdk.org>
Committer: Ambarish Rapte <arapte at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/c4cc99882928e423003d54cae0a6b0de2ec05007
Stats:     321 lines in 8 files changed: 291 ins; 6 del; 24 mod

8196065: ListChangeListener getRemoved() returns items that were not removed.

Reviewed-by: arapte, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/478


More information about the openjfx-dev mailing list