RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

[Phil Race]

On Fri, 25 Jun 2021 21:13:31 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8223717: javafx printing: Support Specifying Print to File in the API
>
> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 492:
> 
>> 490:      * a writable file it may be ignored, or a SecurityException may be thrown.
>> 491:      * The default value is an empty string, which is interpreted as unset,
>> 492:      * which means output is sent to the printer.
> 
> Can you add a `* @defaultValue empty string` javadoc tag?

will do  ..

> tests/manual/printing/PrintToFileTest.java line 134:
> 
>> 132:             job.printPage(printNode);
>> 133:             job.endJob();
>> 134:             if (f.exists()) {
> 
> I have only tried this on Windows. This check is failing for me when I run the test, and yet the file is created correctly. If I add a short sleep, it works (so the printing is likely being done on a different thread).

interesting. I guess I will have to add a sleep as you did.

> tests/manual/printing/PrintToFileTest.java line 137:
> 
>> 135:                 System.out.println("created file");
>> 136:                 passed = true;
>> 137:                 f.delete();
> 
> Maybe leave the file? I found it useful to verify its contents.

ok

-------------

PR: https://git.openjdk.java.net/jfx/pull/543