RFR: 8258499: JavaFX: Move src.zip out of the lib directory

[Kevin Rushforth]

On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. It provides a `src.zip` file for use by IDEs in that same `lib` directory. If a developer adds the `lib` directory to their application's module path in the IDE, it will try to load `src.zip` as if it were a jar file, and will fail. This is a pain point for developers using the SDK. 
> 
> The proposed solution is to move the `src.zip` file from the lib directory to the top directory of the SDK.
> 
> With this fix, the layout of the SDK will be:
> 
> 
> <sdk>/
>     bin/                      (Windows)
>         <native libraries>    (Windows)
> 
>     legal/
>         ...
> 
>     lib/
>         *.jar
>         <native libraries>    (macOS and Linux)
> 
>     src.zip
> 
> 
> NOTES:
> 1. The JavaFX Eclipse plugin will need a minor change, which is tracked by eclipse-efx/efxclipse-eclipse#85.
> 2. This still needs to be tested on IntelliJ

Thanks for running the test. This is sufficient to show that the changed layout will work with IntelliJ.

What happens with the current layout, where src.zip is in the lib dir, if you add the lib dir? Does IntelliJ fail in the same way as NetBeans (complain about duplicates)?

-------------

PR: https://git.openjdk.java.net/jfx/pull/558