RFR: 8089913: CSS styling problem with Slider pseudo classes

Kevin Rushforth kcr at openjdk.java.net
Fri Mar 5 01:26:52 UTC 2021


On Wed, 3 Mar 2021 16:40:27 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> @mstr2 can you enable pre-submit testing for your repo as indicated the Checks section? You might need to then push a new (empty) commit to your branch in order to trigger the tests to run.
>
> side note: there might be a similar issue in other controls, f.i. the pseudoState of ListView orientation doesn't seem to be initialized

The fix and test look good.

@kleopatra Good catch about the same problem occurring in other controls. I did a quick scan, and the same bug exists in at least `ListView`, which should initialize the VERTICAL PseudoClass in its constructor. Most of the others looked fine, except for the following, which need to be checked more carefully:

TableView
TreeTableView
TreeCell
TreeTableRow


@mstr2 I think the scope of this bug should be expanded to fix at least the `ListView` issue, since it is effectively the same bug as this, with the same pattern used for the fix and test. The Tree/TableView classes could be looked at separately, unless you would like to take a closer look.

-------------

PR: https://git.openjdk.java.net/jfx/pull/413


More information about the openjfx-dev mailing list