RFR: 8204568: Relative CSS-Attributes don't work all time [v3]

Ambarish Rapte arapte at openjdk.java.net
Fri Mar 5 17:42:25 UTC 2021


> Issue is that the size of properties that are relatively(`em`) sized is not computed correctly when the reference `-fx-font-size` is also specified relatively and is nested.
> 
> Fix is a slight variation of an earlier suggestion in [the PR](https://github.com/javafxports/openjdk-jfx/pull/94).
> 
> Fix is very specific to this scenario and did not show any side effect nor any test failure.
> 
> There are 12 new unit tests added along with fix:
> - Two tests fail before and pass after this fix. These test verify the reported failing scenario.
> sameRelativeFontSizeNestedParentTest
> relativeFontSizeDeepNestedParentControlTest
> - Two other tests fail both before and after this fix. They are not related to the fix. These two tests are ignored. I shall file new JBS issues to track these cases and update PR with the IDs added to @Ignore.
> propertySizesRelativeToFontSizeOfControlTest
> propertySizesRelativeToFontSizeOfParentTest
> - Other 8 tests are sanity tests which pass both before and after this fix.

Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - update to address review
 - Merge branch 'master' into 8204568_css_relative_size
 - update to recalculate properties when font size changes
 - fix and test

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/397/files
  - new: https://git.openjdk.java.net/jfx/pull/397/files/816304de..1b17d26a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=397&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=397&range=01-02

  Stats: 2293 lines in 85 files changed: 1874 ins; 240 del; 179 mod
  Patch: https://git.openjdk.java.net/jfx/pull/397.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/397/head:pull/397

PR: https://git.openjdk.java.net/jfx/pull/397


More information about the openjfx-dev mailing list