RFR: 8260528: Clean glass-gtk sizing and positioning code [v23]
Thiago Milczarek Sayao
tsayao at openjdk.java.net
Sat Mar 6 23:56:16 UTC 2021
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more "straightforward" and easier to maintain.
>
> Current status (Ubuntu 20.04):
> 
>
> (*) Some of the iconify tests are also failing on the main branch.
>
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2 failures.
Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
- Replace the window size & positining code
Default to 320x200 if no size is assigned
Hopefully fix all "extra resize" problems due to frame extents.
Small change to reuse get_net_frame_extents_atom()
Fix more tests (restore 1 behaviour)
More test fixes
Partial progress
Adjust positioning (not 100% yet)
It's looking good. Except for fixed initial extents, but it seems a reasonable fix due to nature o frame extents.
It's probably good now
One more small issue
- Merge pull request #17 from openjdk/master
Pull from origin
- Merge pull request #16 from openjdk/master
Update
- Merge pull request #15 from openjdk/master
Update from jfx
- Merge pull request #14 from openjdk/master
Merge master
- Merge pull request #13 from openjdk/master
Merge master
- Merge pull request #12 from openjdk/master
Merge with main
- Merge pull request #11 from openjdk/master
Merge from upstream
- Merge pull request #10 from openjdk/master
Update from master
- Merge pull request #9 from openjdk/master
Merge from upstream
- ... and 5 more: https://git.openjdk.java.net/jfx/compare/e394b0a6...34518b8e
-------------
Changes: https://git.openjdk.java.net/jfx/pull/367/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=367&range=22
Stats: 630 lines in 5 files changed: 170 ins; 337 del; 123 mod
Patch: https://git.openjdk.java.net/jfx/pull/367.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/367/head:pull/367
PR: https://git.openjdk.java.net/jfx/pull/367
More information about the openjfx-dev
mailing list