RFR: 8206253: No/Wrong scroll events from touch input in window mode
Johan Vos
jvos at openjdk.java.net
Tue Mar 9 09:07:10 UTC 2021
On Mon, 8 Mar 2021 23:43:10 GMT, Jose Pereda <jpereda at openjdk.org> wrote:
> This PR changes the parameter names to accommodate class calculations related to screen event coordinates (AbsX, AbsY).
>
> As [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14405707), the sendScrollXXXEvent methods are currently passing the screen coordinates (AbsX, AbsY) to the local ones, but they shouldn't modify those, but the screen ones.
>
> Tested successfully on Android with ComboBox controls in different positions.
modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ScrollGestureRecognizer.java line 265:
> 263: }
> 264:
> 265: private void sendScrollStartedEvent(double centerAbsX, double centerAbsY, int touchCount) {
It's probably better to use other names here, as centerAbsX/Y are already used as instance variables.
-------------
PR: https://git.openjdk.java.net/jfx/pull/420
More information about the openjfx-dev
mailing list