RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

Jose Pereda jpereda at openjdk.java.net
Tue Mar 9 18:51:22 UTC 2021


On Tue, 9 Mar 2021 16:42:09 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ScrollGestureRecognizer.java line 265:
>> 
>>> 263:     }
>>> 264: 
>>> 265:     private void sendScrollStartedEvent(double centerAbsX, double centerAbsY, int touchCount) {
>> 
>> It's probably better to use other names here, as centerAbsX/Y are already used as instance variables.
>
> Yes, that makes sense. 
> 
> We could refactor the three `sendScrollXXXEvent` methods to something like:
> 
> sendScrollXXXEvent(double xAbs, double yAbs, int touchCount)
> or to:
> 
> sendScrollXXXEvent(double x, double y, double xAbs, double yAbs, int touchCount)
> 
> Any preference?

For now, I've done the first approach, given that there is no conflict with the `centerX, centerY` variables.

-------------

PR: https://git.openjdk.java.net/jfx/pull/420


More information about the openjfx-dev mailing list