RFR: 8263322: Deadlock when calling Application.launch in the FXThread after Platform.startup [v2]
Florian Kirmaier
fkirmaier at openjdk.java.net
Wed Mar 10 16:26:11 UTC 2021
On Wed, 10 Mar 2021 13:15:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - JDK-8263322
>> Added missing change
>> - JDK-8263322
>> Small changes based on code review
>> - JDK-8263322
>> Small changes based on code review
>
> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line 36:
>
>> 34: latch.countDown();
>> 35: });
>> 36: latch.await();
>
> This needs to be changed to a flavor of await with a timeout (you can assert that it doesn't timeout). Also, I don't think this needs to be its own method, since the only thing the `initialize` method does is call this.
I actually prefer it as a separate method. It makes it more reusable. And it makes it also easier to compare the behavior, between the two possible ways to initialize JavaFX
-------------
PR: https://git.openjdk.java.net/jfx/pull/421
More information about the openjfx-dev
mailing list