RFR: 8263322: Deadlock when calling Application.launch in the FXThread after Platform.startup [v4]

Kevin Rushforth kcr at openjdk.java.net
Fri Mar 12 16:32:11 UTC 2021


On Fri, 12 Mar 2021 14:31:17 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java line 80:
>> 
>>> 78:                 System.out.println("Finished launch!");
>>> 79:                 Assert.fail("Error: No Exception was thrown - expected IllegalStateException");
>>> 80:             } catch (IllegalStateException e) {
>> 
>> Maybe add a comment that this exception is expected?
>
> I've added a comment and a print-statement that this is expected - on both catches for EllegalStateException

The comment looks fine. See my global comment about the print statement.

-------------

PR: https://git.openjdk.java.net/jfx/pull/421


More information about the openjfx-dev mailing list