RFR: 8261840: Submenus close to screen borders are no longer repositioned

[Robert Lichtenberger]

On Fri, 12 Mar 2021 13:59:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Marked as reviewed by aghaisas (Reviewer).
>
> This fixes the bug in question, although I see a slight regression in behavior on Windows with 125% pixel scaling (it doesn't reproduce with any other scaling value that I tried). With the original test case for [JDK-8228363](https://bugs.openjdk.java.net/browse/JDK-8228363), and `TOP` as the value of `side`, the initial menu is positioned slightly lower (by a few pixels) than it should be. See the attached image. It is correct the second and subsequent times the context menu is opened.
> 
> Given that this new bug only happens with 125% scaling, it seems likely that it is a preexisting bug, and this fix merely exposes it. Can you take a look at this? If it is preexisting, then we should file a follow-on bug for this.
> 
> ![ContextMenu-125](https://user-images.githubusercontent.com/34689748/110947924-9991ce00-82f5-11eb-82d2-6959ef24293f.png)

Yes I can try to look into this.

On 3/12/21 2:59 PM, Kevin Rushforth wrote:
>
> This fixes the bug in question, although I see a slight regression in 
> behavior on Windows with 125% pixel scaling (it doesn't reproduce with 
> any other scaling value that I tried). With the original test case for 
> JDK-8228363 <https://bugs.openjdk.java.net/browse/JDK-8228363>, and 
> |TOP| as the value of |side|, the initial menu is positioned slightly 
> lower (by a few pixels) than it should be. See the attached image. It 
> is correct the second and subsequent times the context menu is opened.
>
> Given that this new bug only happens with 125% scaling, it seems 
> likely that it is a preexisting bug, and this fix merely exposes it. 
> Can you take a look at this? If it is preexisting, then we should file 
> a follow-on bug for this.
>
> ContextMenu-125 
> <https://user-images.githubusercontent.com/34689748/110947924-9991ce00-82f5-11eb-82d2-6959ef24293f.png>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
> <https://github.com/openjdk/jfx/pull/410#issuecomment-797506928>, or 
> unsubscribe 
> <https://github.com/notifications/unsubscribe-auth/ABCKAQ667DN5I4VPLF37ACTTDIF23ANCNFSM4YCWEUJQ>.
>

-------------

PR: https://git.openjdk.java.net/jfx/pull/410