RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

[Kevin Rushforth]

On Sun, 21 Mar 2021 17:48:10 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> I would like to allow a developer to achieve a functionality like is shown in https://www.youtube.com/watch?v=CFgwZX5dkcM at 9:50. The rotations are intuitive there. If we allow both rotation transforms and a direction, wouldn't that cause the direction to be unintuitive? Or do you mean that the direction is always the look-at regardless of rotation transforms and if it's `null` then the rotations take over?

I the rotation needs to apply to whatever the direction vector is: whether that's implicitly (0,0,1) if we don't provide a separate direction vector or whether it's the user provided direction vector, it would be odd to ignore transforms if you set the vector.

If we don't provide a vector, we could always add it later if people ask for it, so maybe it is better to leave it off if we aren't sure.

The question then becomes how easy is it to modify the direction vector using the node transforms?

> > On Mac I no longer get a GLSL shader error at runtime, but spotlights aren't working correctly, either.
> 
> I don't see this on Linux and I don't have a Mac. Can you try on Linux and see what you get? If Linux works, I'm afraid I would not be able to debug the Mac.

It's broken on Linux, too -- more so, since there is no lighting most of the time.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334