RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]
Jeanette Winzenburg
fastegal at openjdk.java.net
Tue Mar 23 11:43:41 UTC 2021
On Mon, 22 Feb 2021 20:29:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> Not yet reviewed. All of the new API methods need to have an `@since 17` javadoc tag.
wondering about the sequence of next steps: should I create the csr before or after (partial) review of this? Doing before feels like expecting duplicate work (whenever doc changes are required, I'll have to change the code in the pr and the csr draft as well, I assume). If that's the way, I'll go it, naturally :)
-------------
PR: https://git.openjdk.java.net/jfx/pull/409
More information about the openjfx-dev
mailing list