RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]
Kevin Rushforth
kcr at openjdk.java.net
Tue Mar 23 15:20:43 UTC 2021
On Tue, 23 Mar 2021 11:41:23 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> Not yet reviewed. All of the new API methods need to have an `@since 17` javadoc tag.
>
> wondering about the sequence of next steps: should I create the csr before or after (partial) review of this? Doing before feels like expecting duplicate work (whenever doc changes are required, I'll have to change the code in the pr and the csr draft as well, I assume). If that's the way, I'll go it, naturally :)
I'll review the API changes in the next day or so. Then you can update the CSR and move to Proposed. I'll also ask Ambarish to be the second reviewer on this.
-------------
PR: https://git.openjdk.java.net/jfx/pull/409
More information about the openjfx-dev
mailing list