Integrated: 8264061: LocalDateTimeStringConverterTest fails in Canada

John Neffenger jgneff at openjdk.java.net
Tue Mar 23 22:58:39 UTC 2021


On Tue, 23 Mar 2021 18:24:40 GMT, John Neffenger <jgneff at openjdk.org> wrote:

> As the comment in the test case mentions, "Tests require that default locale is en_US." The default locale is required by the objects created in the static method `implementations`, marked with the JUnit annotation `@Parameterized.Parameters`. So the static method `initDefaultLocale`, marked with the JUnit annotation `@BeforeClass`, calls the method to set the required default:  `Locale.setDefault(Locale.US)`.
> 
> The problem occurs because the `@Parameterized.Parameters` method is called before the `@BeforeClass` method, so the system locale is used as the default instead of `Locale.US`.
> 
> The fix is to move the call to the first instruction of the `@Parameterized.Parameters` method so that the default is set before it's required.

This pull request has now been integrated.

Changeset: 3bbcf977
Author:    John Neffenger <jgneff at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/3bbcf977
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8264061: LocalDateTimeStringConverterTest fails in Canada

Reviewed-by: kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/438


More information about the openjfx-dev mailing list