RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

Nir Lisker nlisker at openjdk.java.net
Thu Mar 25 13:17:38 UTC 2021


On Thu, 25 Mar 2021 11:25:18 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> I reviewed only the public API methods.
>
> @nlisker thanks for the detailed doc review - I really like your suggestions, which I think are considerable improvements (I did part of it in the respective methods of the handler) over the original doc :)  Because that's what the doc of the new methods are: c&p from the un/registerChangeListener javadoc, adjusted to the specific type of the listener. 
> 
> For consistency, all related method doc should be improved along your lines. How to get there? Options
> 
> - use old doc with new methods, leave improving the doc for all methods to a follow-up issue
> - keep old doc for old method, use improved doc for the new methods, leave improving the doc for the old method to a follow-up issue
> - use improved doc in old and new methods in this issue, changing the old
> 
> Last would be doing it right once and for all .. my reluctant (against my lazy self ;) preference would be the last.

Can you list the other affected methods?

-------------

PR: https://git.openjdk.java.net/jfx/pull/409


More information about the openjfx-dev mailing list