RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

Florian Kirmaier fkirmaier at openjdk.java.net
Fri Mar 26 12:02:42 UTC 2021


On Tue, 23 Mar 2021 09:57:11 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8263402
>>   Rewrote the style memoryleak test
>
> Provided few comments on test.

I've added the requested changes from the codereview

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 48:
> 
>> 46: import static org.junit.Assert.fail;
>> 47: import static org.junit.Assert.assertTrue;
>> 48: 
> 
> The packages Application, Node and Parent are not used.

done

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 100:
> 
>> 98:         Platform.runLater(() -> {
>> 99:             Platform.exit();
>> 100:         });
> 
> `Platform.exit()` can be called from any thread. So `Platform.runLater` is not required.

done

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 102:
> 
>> 100:         });
>> 101:     }
>> 102: }
> 
> Include a new line at end of file.

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/424


More information about the openjfx-dev mailing list