RFR: 8258663: Fixed size TableCells are not removed from sene graph when column is removed [v2]

[Marius Hanl]

On Wed, 31 Mar 2021 12:32:02 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> 
> 
> Fix looks good, verified failing/passing test before/after fix. Left minor comments inline.
> 
> As to the test - good to increase test coverage by including tests for invisible columns, IMO :)
> 
> Two thingies you might consider (your decision, I'm fine either way)
> 
>     * test TreeTable also? Which doesn't seem to have the issue, so would be okay not to .. just for sanity.
> 
>     * parameterize the test in fixedSize false/true

I didn't wrote tests for TreeTableView, as they have no issue (and I'm lazy :P). But it might be a good idea to do so in future. 

I chose not to make the tests parameterized so other people can add tests as well (without the parameterized 'dependency'). As far as I saw, you can't just define some tests to be parameterized (only the whole class is). I know that his is possible in JUnit5 with @MethodSource, but unfortunatly we run on JUnit4.

-------------

PR: https://git.openjdk.java.net/jfx/pull/444