RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v9]
Ambarish Rapte
arapte at openjdk.java.net
Wed May 5 09:34:55 UTC 2021
On Mon, 3 May 2021 20:51:13 GMT, mstr2 <github.com+43553916+mstr2 at openjdk.org> wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which incorrectly computed adjacent removed indices, thus resulting in incorrect removal notifications.
>>
>> Since there were no unit tests for this method, I also added a bunch of tests.
>>
>> After applying this fix, I can no longer reproduce [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228).
>
> mstr2 has updated the pull request incrementally with two additional commits since the last revision:
>
> - Rename local variable in test
> - Remove unrelated fix
We couple more similar issues reported
1. [JDK-8255935](https://bugs.openjdk.java.net/browse/JDK-8255935) : MultipleSelectionModel provides incorrect 'removed' sub-list in change events
2. [JDK-8196065](https://bugs.openjdk.java.net/browse/JDK-8196065) : ListChangeListener getRemoved() returns items that were not removed.
-------------
PR: https://git.openjdk.java.net/jfx/pull/480
More information about the openjfx-dev
mailing list