RFR: 8264157: Items of non-editable ComboBox cannot be selected using up/down keys

Jeanette Winzenburg fastegal at openjdk.java.net
Wed May 5 10:36:52 UTC 2021


On Tue, 4 May 2021 12:29:54 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> This issue [JDK-8264157](https://bugs.openjdk.java.net/browse/JDK-8264157) is a regression of [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788), which removed two KeyMappings from `ComboBoxListViewBehavior`. That removal was not required to fix [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788).
> Reverting `ComboBoxListViewBehavior.java` fixes the regression.
> Fix includes a new test which fails before and pass with the fix.

fix looks good, verified test failing before and passing after - crossing fingers we got it completely right this time :)

-------------

Marked as reviewed by fastegal (Committer).

PR: https://git.openjdk.java.net/jfx/pull/485


More information about the openjfx-dev mailing list