Integrated: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

mstr2 github.com+43553916+mstr2 at openjdk.java.net
Mon May 10 13:21:05 UTC 2021


On Sat, 24 Apr 2021 04:11:28 GMT, mstr2 <github.com+43553916+mstr2 at openjdk.org> wrote:

> This PR fixes the implementation of `ControlUtils.reducingChange`, which incorrectly computed adjacent removed indices, thus resulting in incorrect removal notifications.
> 
> Since there were no unit tests for this method, I also added a bunch of tests.
> 
> After applying this fix, I can no longer reproduce [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228).

This pull request has now been integrated.

Changeset: eb913cb7
Author:    mstr2 <43553916+mstr2 at users.noreply.github.com>
Committer: Ambarish Rapte <arapte at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/eb913cb78bbc7a4973d1dfab3b02335edeff72aa
Stats:     77 lines in 5 files changed: 46 ins; 26 del; 5 mod

8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

Reviewed-by: arapte, fastegal

-------------

PR: https://git.openjdk.java.net/jfx/pull/480


More information about the openjfx-dev mailing list