RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v4]
Michael Strauß
mstrauss at openjdk.java.net
Tue May 11 01:47:26 UTC 2021
> The documentation for `ObservableListBase.nextRemove` states that a single change always refers to the current state of the list, which likely means that multiple disjoint removed ranges need to be applied in order, otherwise the next change's `getFrom` doesn't refer to the correct index.
>
> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, which means that subsequent removals will refer to the wrong index when retrieving the removed elements. This PR fixes the calculation of the current index.
Michael Strauß has updated the pull request incrementally with two additional commits since the last revision:
- Fixed clear-and-select change notification
- Add failing tests
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/478/files
- new: https://git.openjdk.java.net/jfx/pull/478/files/d739a993..1219b6af
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=478&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=478&range=02-03
Stats: 121 lines in 6 files changed: 87 ins; 10 del; 24 mod
Patch: https://git.openjdk.java.net/jfx/pull/478.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/478/head:pull/478
PR: https://git.openjdk.java.net/jfx/pull/478
More information about the openjfx-dev
mailing list