RFR: 8263760: Update gradle to version 7.0.1
Kevin Rushforth
kcr at openjdk.java.net
Thu May 13 21:37:16 UTC 2021
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> This PR fixes the gradle deprecation warnings described in [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates the JavaFX build to use gradle 7.0.1 as described in [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760). The minimum version of gradle is set to 6.3.
>
> In addition to keeping gradle up to date, updating to gradle 7 will allow building and testing JavaFX with JDK 16.
>
> I have done a full build and test on all three platforms, comparing the artifacts produced before and after this change.
>
> ### Notes to Reviewers:
>
> The PR branch has two separate commits, one for each fix, in case reviewers want to look at them separately. As always, they will be squashed into a single commit when integrated. Both bug IDs will be listed in the commit.
>
> The following changes were done for [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) to eliminate the use of deprecated features removed in gradle 7:
>
> 1. Replaced `compile` with either `implementation` or `compileClasspath` as needed
> 2. Replaced obsolete `archiveName` and `destinationDir` properties in archive tasks with `archiveFileName` and `destinationDirectory`
> 3. Added missing `@Input` annotation to custom Groovy task properties
> 4. Bumped the minimum version of gradle to 6.3 (which we have been using for more than 1 year)
>
>
> The following changes were done for [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760) to update to gradle 7.0.1:
>
> 1. Ran `bash ./gradlew wrapper --gradle-version=7.0.1`
> 2. Updated the gradle version in `build.properties` to `7.0.1`
> 3. Updated the SHA-256 checksum in `gradle/wrapper/gradle-wrapper.properties`
On closer inspection, I am reverting my earlier change to `gradlew` (the one that reverted the setting of `DEFAULT_JVM_OPTS` to a 64Mbyte heap). The `gradle` launcher in gradle 7.0.1 also sets its `DEFAULT_JVM_OPTS` to a 64Mbyte heap as you can see in the following, taken from `gradle-7.0.1/bin/gradle`:
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
So even though I agree that a 64 Mbyte heap is a bit on the small side, it's more important that running `gradlew` behave the same as installing gradle and running `$GRADLE_HOME/bin/gradle`. Plus I'd prefer not to maintain local modifications of this upstream script.
-------------
PR: https://git.openjdk.java.net/jfx/pull/498
More information about the openjfx-dev
mailing list