RFR: 8267160: Monocle mouse never get ENTERED state

Kevin Rushforth kcr at openjdk.java.net
Fri May 14 15:42:40 UTC 2021


On Fri, 14 May 2021 14:37:04 GMT, Johan Vos <jvos at openjdk.org> wrote:

> allow to pass a fallback window in case the existing one is null (or can't be computed).
> 
> Fix for JDK-8267160

I'm not sure I understand the fix. Questions inline.

modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MouseState.java line 94:

> 92:      */
> 93:     MonocleWindow getWindow(boolean recalculateCache, MonocleWindow fallback) {
> 94:         if (recalculateCache) {

Two questions:

1. It looks like `fallback` is effectively unused (always null). Did you add this for a future use case?
2. Unless I'm missing something, the only behavioral change is that it no longer executes the `if` block when the window is null if `recalculateCache` is false.

-------------

PR: https://git.openjdk.java.net/jfx/pull/502


More information about the openjfx-dev mailing list