RFR: 8266860: [macos] Incorrect duration reported for HLS live streams
Kevin Rushforth
kcr at openjdk.java.net
Sat May 15 12:49:43 UTC 2021
On Tue, 11 May 2021 23:43:36 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number double value) and our code expects -1.0. Based on doc we should be using CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using CMTIME_IS_INDEFINITE to test if duration is indefinite and if true -1.0 will be return to our Java layer.
I requested 2 reviewers before I reviewed the fix, since changes in media are usually complex enough that a second reviewer is needed. In this case the fix is simple and obvious, so I don't think a second reviewer is required.
@sashamatveev I recommend to wait until later in the day Monday to integrate this in case anyone else wants to take a look.
-------------
PR: https://git.openjdk.java.net/jfx/pull/495
More information about the openjfx-dev
mailing list