RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
Ambarish Rapte
arapte at openjdk.java.net
Mon May 17 12:50:57 UTC 2021
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
> The test fails intermittently on github build. But I do not observe this issue locally on my Ubuntu20.04 VM.
> I am suspecting that the reason of failure is that the test are not cleaned up correctly. The changes in this PR cleans up the test, by removing all children added to root and hiding the stage.
Hello Kevin,
Adding a call to `StyleManager.getInstance().forget(scene)` seems like a proper fix because it clears the `StyleManager`.
This PR executed the tests two times using only this call and did not fail the test.
Does this look good OR
should we also include `root.getChildren().clear()` and `stage.hide()` calls ?
-------------
PR: https://git.openjdk.java.net/jfx/pull/496
More information about the openjfx-dev
mailing list