Integrated: 8267121: Illegal access to private "size" field of ArrayList from build.gradle

Kevin Rushforth kcr at openjdk.java.net
Mon May 17 13:04:42 UTC 2021


On Sat, 15 May 2021 12:42:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug in `build.gradle` in the `fetchExternalTools()` method. It checks the size of an `ArrayList` in two places, but rather than calling the `size()` method it omits the `()` which means it is accessing the private `size` field.
> 
> Starting in JDK 16, which has default strong encapsulation, this no longer works, so we need to fix this before switching. We really should fix it anyway, since accessing the internal field is both unnecessary and wrong.

This pull request has now been integrated.

Changeset: 9c97d9b2
Author:    Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/9c97d9b21232a67a10debdc8dc3b10c419780f7a
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8267121: Illegal access to private "size" field of ArrayList from build.gradle

Reviewed-by: arapte, jvos

-------------

PR: https://git.openjdk.java.net/jfx/pull/503


More information about the openjfx-dev mailing list