RFR: 8264127: ListCell editing status is true, when index changes while editing [v13]

[Florian Kirmaier]

On Mon, 17 May 2021 08:40:44 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8264127
>>   More changes, simplifications and tests based on CR
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java line 936:
> 
>> 934:             assertFalse("cell must not be editing", cell.isEditing());
>> 935:             assertEquals("table must be editing at intermediate index", intermediate, list.getEditingIndex());
>> 936:         }
> 
> that's good - except for a minor omission: the catch-block is never reached, instead it is printed to sysout (or syserr, don't nail me) That happens because ExpressionHelper kind of swallows all exceptions in change notifications by passing them to the uncaughtExceptionHandler. To fix this, a test should un-/install (in After/Before methods) an uncaught exception handler. For examples, see f.i. TableCellTest.
> 
> really minor: replace "table" by "list" in the failure message :)

I've now added the exception handler, like in TreeCellTest.

And I've fixed the texts of the failure messages.

-------------

PR: https://git.openjdk.java.net/jfx/pull/441