RFR: 8267392: ENTER key press on editable TableView throws NPE

Wed May 19 14:08:48 UTC 2021

On Wed, 19 May 2021 11:03:52 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> 
> 
> sounds like a duplicate of [JDK-8089652](https://bugs.openjdk.java.net/browse/JDK-8089652) - faintly remember that it's a dark pit: there are issues in selection/focus model implementations, see f.i. [JDK-8219720](https://bugs.openjdk.java.net/browse/JDK-8219720). Starting with fixing the NPE is goood :))

Should I add this issue to this PR then? I'm not sure, as with my fix, ENTER won't start editing the cell still. This is due the whole row is initially focused, not a particular cell (getFocusModel().focus(row) -> no table column will be set inside the focused cell table position). 
The only difference you will see, when pressing ENTER, is a change from the focused state (this light blue border) to the selected state (row is highlighted blue) and of course no NPE inside the console. ��

-------------

PR: https://git.openjdk.java.net/jfx/pull/505