RFR: 8267392: ENTER key press on editable TableView throws NPE [v2]
Marius Hanl
github.com+66004280+maran23 at openjdk.java.net
Wed May 19 14:15:01 UTC 2021
On Wed, 19 May 2021 12:15:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed review comment (changed from NP to NPE)
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java line 196:
>
>> 194:
>> 195: @Test
>> 196: public void testEnterOnFocusedRowDoesNotThrowNP() {
>
> The usual abbreviation for NullPointerException is `NPE` rather than `NP`, so I recommend updating the test method names and comments accordingly.
You are right, my bad. Fixed it. :)
-------------
PR: https://git.openjdk.java.net/jfx/pull/505
More information about the openjfx-dev
mailing list