RFR: 8267425: Intermittent failure of HonorDeveloperSettingsTest unit test

Thu May 20 23:51:46 UTC 2021

On Thu, 20 May 2021 07:18:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> The same failure was earlier fixed at PR #496, which seems insufficient.
> The changes in this PR were also tried ealier in the PR #496 but later removed, as they seemed not necessary.
> Fix is to clean up the test, by removing all children added to root and hiding the stage.
> The test only fails on the GHA run, if it continues to fail after this fix then we shall skip it till next test sprint.

The cleanup looks safe enough, although I still don't think that removing the children is needed.

I took a look at what the `resetStyleManager` method in the test does, and it seems like clearing `StyleManager::cacheContainerMap` should have prevented any leftovers from the old scene from being processed the next time around. And yet that's what it looks like is happening. I'd prefer to understand why it is causing a problem rather than just adding more cleanup and hoping that it's enough this time. I'll take a closer look tomorrow.

-------------

PR: https://git.openjdk.java.net/jfx/pull/509