Make themes a first-class concept in JavaFX

[Kevin Rushforth]

Please file an Enhancement request first, and from that enhancement 
create a new CSR. Ideally JBS would prevent direct creation of an issue 
with an issuetype of CSR.

As for the feature itself, it seems useful, but will need discussion as 
to the value proposition (i.e., cost / benefit), and then agreement on 
the API itself. One thing that would help in this is some discussion 
around how an application developer would use it.

I have one initial comment on the currently proposed API. You'll likely 
need to rethink your proposed change to the STYLESHEET_CASPIAN and 
STYLESHEET_MODENA constants. It seems attractive to change it for 
consistency, but it is an incompatible change. It is likely there are 
applications or third-party controls that rely on the current values. 
Also, it leaks the name of the internal com.sun.javafx.* package where 
it happens to live today, which is an implementation detail. I think you 
should stick with the existing constants and translate it on use in the 
implementation as needed.

-- Kevin


On 5/21/2021 8:39 AM, Michael Strauß wrote:
> Here's a CSR that explains the details of the proposed public API:
> https://bugs.openjdk.java.net/browse/JDK-8267540