RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]
Nir Lisker
nlisker at openjdk.java.net
Mon May 24 05:08:14 UTC 2021
On Fri, 16 Apr 2021 13:33:36 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 46:
>>
>>> 44: * <p>
>>> 45: * The light cone is defined by 3 factors: an {@link #innerAngleProperty() inner angle}, an {@link #outerAngleProperty()
>>> 46: * outer angle}, and a {@link #falloffProperty() falloff} factor. For a point whose angle to the light is {@code a}, if
>>
>> ->
>> A {@code SpotLight} is a {@code PointLight} that radiates a cone of light in a specific direction.
>> < p >
>> The direction is defined by the {@link #directionProperty() direction} property.
>> The light cone is defined by 3 properties: an {@link #innerAngleProperty() inner angle}, an {@link #outerAngleProperty() outer angle}, and a {@link #falloffProperty() falloff} property.
>
> Also Will it be illustrative to mention these three properties using li tags with a statement that briefs the use of property.
> Something like,
> - {@link #innerAngleProperty() inner angle}: Angle of the inner cone where light intensity is always maximum.
> - {@link #outerAngleProperty() outer angle}: Angle of the outer cone where light intensity attenuates based on fallof.
> - {@link #falloffProperty() falloff}: The attenuation factor that controls the attenuation of light intensity from edge of inner cone to the edge of outer cone.
I used bullet points, but the descriptions of the intensity behaviors are described later anyway in more detail, so I kept these short.
-------------
PR: https://git.openjdk.java.net/jfx/pull/334
More information about the openjfx-dev
mailing list