RFR: 8265210: TreeCell: cell editing state not updated on cell re-use

[Ajit Ghaisas]

On Thu, 13 May 2021 12:22:47 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> fix is analogous to similar issues for Tree/TableCell (combined [JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) and [JDK-8265206](https://bugs.openjdk.java.net/browse/JDK-8265206))
> 
> added tests that failed before and passed after the fix
> 
> note: this PR also adds two asserts (which I forgot in the previous [PR 473](https://github.com/openjdk/jfx/pull/473);) in Tree/TableEditingTest which are unrelated to this fix.

The fix looks good to me.
I have made one minor test cleanup observation. Once fixed, it it ready to be pushed.

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeCellEditingTest.java line 45:

> 43: import javafx.scene.control.TreeCell;
> 44: import javafx.scene.control.TreeItem;
> 45: //import javafx.scene.control.TableColumn;

Minor - 2 commented imports can be removed.

-------------

PR: https://git.openjdk.java.net/jfx/pull/501